fix(board-db): add Seeed XIAO BLE / BLE Sense (nRF52840) board defs#294
Conversation
`fbuild`'s bundled board DB
(`crates/fbuild-config/assets/boards/json/`, loaded at compile time via
`include_dir!`) was missing both Seeed XIAO BLE variants. Every
downstream consumer of `xiaoble_adafruit` or `xiaoblesense_adafruit`
(notably FastLED's `nrf52_xiaoblesense` and `adafruit_xiaoblesense`
workflows) hit:
build error: config error: unknown board 'xiaoble_adafruit' (no built-in defaults)
build error: config error: unknown board 'xiaoblesense_adafruit' (no built-in defaults)
before any code was compiled. fbuild does not consult
`~/.platformio/platforms/` at runtime, so the maxgerhardt platform's
board JSONs are invisible — they must be baked into the bundle.
Add both JSONs to the bundle, mirroring the values from
maxgerhardt/platform-nordicnrf52/boards/{xiaoble_adafruit,
xiaoblesense_adafruit}.json (develop branch):
- mcu = NRF52840, fcpu = 64 MHz
- core = nRF5, variant = Seeed_XIAO_nRF52840[_Sense]
- ldscript = nrf52840_s140_v7.ld
- ram = 237568, rom = 811008 (from upstream
upload.maximum_ram_size / maximum_size)
- platform = nordicnrf52
Add regression tests
`test_xiaoble_adafruit_board_config` and
`test_xiaoblesense_adafruit_board_config`. All 55 board tests pass.
Fixes #293
|
Warning Review limit reached
More reviews will be available in 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
fbuild's bundled board DB (crates/fbuild-config/assets/boards/json/) was missing both Seeed XIAO BLE variants. Every downstream consumer ofxiaoble_adafruitorxiaoblesense_adafruithitconfig error: unknown board 'X' (no built-in defaults)before any code was compiled.~/.platformio/platforms/at runtime, so maxgerhardt platform's board JSONs are invisible — they must be baked into the bundle (theenrich_boardsmaintenance bin is the canonical path, but these boards never made it through).maxgerhardt/platform-nordicnrf52/boards/{xiaoble_adafruit,xiaoblesense_adafruit}.json(develop branch):Seeed_XIAO_nRF52840/Seeed_XIAO_nRF52840_Sensenrf52840_s140_v7.ldupload.maximum_ram_size/maximum_size)nordicnrf52nrf52_xiaoblesense(→xiaoble_adafruit),adafruit_xiaoblesense(→xiaoblesense_adafruit). Both fail every example in each workflow.Test plan
cargo check -p fbuild-config— clean.cargo test -p fbuild-config --lib board::— 55/55 (was 53/53; added two regression tests).nrf52_xiaoblesense+adafruit_xiaoblesenseworkflows after a fbuild bump.Fixes #293
Generated with Claude Code (https://claude.com/claude-code)